Skip to content

Conversation

@philipc2
Copy link
Member

@philipc2 philipc2 commented Apr 13, 2025

Overview

  • Configures the ruff linter to sort imports
  • Updates the pre-commit to check for import sorting

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@philipc2 philipc2 changed the title Configure ruff to perform import sorting Enable import sorting with ruff Apr 13, 2025
@philipc2 philipc2 self-assigned this Apr 13, 2025
@philipc2 philipc2 added the improvement Improvements on existing features or infrastructure label Apr 13, 2025
@philipc2 philipc2 requested a review from Copilot April 14, 2025 18:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 74 out of 74 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.pre-commit-config.yaml:22

  • Duplicate hook id 'ruff' detected. Consider using a unique identifier for the sorting hook (e.g. 'ruff-sort') to avoid potential configuration conflicts.
id: ruff

@philipc2 philipc2 merged commit 68d14f3 into main Apr 17, 2025
20 checks passed
@erogluorhan erogluorhan deleted the ruff-sort-imports branch September 26, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvements on existing features or infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants