-
Notifications
You must be signed in to change notification settings - Fork 45
Add additional variable check to SCRIP reader #1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grid provided in ESMPy ll1deg_grid.nc
Contributor
Author
|
fixes #1234 |
Member
|
@rajeeja looks good, glad you figured this out. Just to clarify, grid_imask is in all scrip files? |
Contributor
Author
|
Satisfies the ones we have on repo, and some I found on the ESMF repo |
Member
Would it be possible to add an or statement to check for all 3: grid_rank=1 grid_imask and/or grid_area? |
Contributor
Author
|
Good idea, that can be done and it'll be more transparent, might add a
debugging statement saying what was found.
…_________________________________________
Rajeev
On Fri, May 2, 2025, 7:17 PM Aaron Zedwick ***@***.***> wrote:
*aaronzedwick* left a comment (UXARRAY/uxarray#1233)
<#1233 (comment)>
Satisfies the ones we have on repo, and some I found on the ESMF repo
What if you added an or statement to check for all 3: grid_rank=1
grid_imask and/or grid_area?
—
Reply to this email directly, view it on GitHub
<#1233 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALF6AUGJVTPHF73TO5X4LT24P4GZAVCNFSM6AAAAAB4KWEFE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBYGI3DEMBWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
aaronzedwick
approved these changes
May 3, 2025
philipc2
requested changes
May 3, 2025
philipc2
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1234
Unstructured SCRIP files may have grid_rank=1 grid_imask and/or grid_area. Some files are found to not have grid_rank and grid_area, so moving to grid_imask
The test file is rather big, so not adding it as our test set is already rather large.