Skip to content

Conversation

@rajeeja
Copy link
Contributor

@rajeeja rajeeja commented May 2, 2025

Closes #1234

Unstructured SCRIP files may have grid_rank=1 grid_imask and/or grid_area. Some files are found to not have grid_rank and grid_area, so moving to grid_imask

The test file is rather big, so not adding it as our test set is already rather large.

@rajeeja rajeeja requested a review from philipc2 May 2, 2025 19:17
@rajeeja rajeeja self-assigned this May 2, 2025
@rajeeja
Copy link
Contributor Author

rajeeja commented May 2, 2025

fixes #1234

@rajeeja rajeeja requested a review from aaronzedwick May 2, 2025 22:44
@aaronzedwick
Copy link
Member

@rajeeja looks good, glad you figured this out. Just to clarify, grid_imask is in all scrip files?

@rajeeja
Copy link
Contributor Author

rajeeja commented May 2, 2025

Satisfies the ones we have on repo, and some I found on the ESMF repo

@aaronzedwick
Copy link
Member

aaronzedwick commented May 2, 2025

Satisfies the ones we have on repo, and some I found on the ESMF repo

Would it be possible to add an or statement to check for all 3: grid_rank=1 grid_imask and/or grid_area?

@rajeeja
Copy link
Contributor Author

rajeeja commented May 2, 2025 via email

@rajeeja rajeeja requested a review from philipc2 May 3, 2025 12:57
@philipc2 philipc2 changed the title SCRIP reader fix Add additional variable check to SCRIP reader May 3, 2025
@philipc2 philipc2 merged commit 8fe4143 into main May 3, 2025
20 checks passed
@erogluorhan erogluorhan deleted the rajeeja/fix_scrip_reader branch September 26, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Script Reader

4 participants