Skip to content

Remove duplicate functions and fix typos in coordinates.py #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rajeeja merged 1 commit into from
Jun 5, 2025
Merged

Remove duplicate functions and fix typos in coordinates.py #1287

rajeeja merged 1 commit into from
Jun 5, 2025

Conversation

@egallmeier
Copy link
Collaborator

@egallmeier egallmeier commented Jun 4, 2025

Closes #1286

Overview

Removes:

  • Line 702 extra _xyz_to_lonlat_rad function
  • Line 752 extra _xyz_to_lonlat_rad_no_norm
  • Line 793 extra _lonlat_rad_to_xyz
  • Line 806 extra _xyz_to_lonlat_deg
  • Line 843 extra _normalize_xyz_scalar

Fixes:

  • Lines 57 & 133 - typo in comment: [0, pi] -> [0,2*pi]
  • Line 185 - spelling mistake "cartesiain" in comment

kafitzgerald
kafitzgerald approved these changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

philipc2
philipc2 approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@rajeeja rajeeja merged commit eef71ce into main Jun 5, 2025
20 checks passed
@erogluorhan erogluorhan deleted the fix-1286 branch September 26, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kafitzgerald kafitzgerald kafitzgerald approved these changes

@philipc2 philipc2 philipc2 approved these changes

Assignees

@egallmeier egallmeier

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicate functions in coordinates.py

5 participants

@egallmeier @kafitzgerald @philipc2 @rajeeja