-
Notifications
You must be signed in to change notification settings - Fork 45
Gradient Operator #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradient Operator #1313
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
This should be good for a review now. |
Thanks, will do it today |
+1 |
|
Thank you both! |
rajeeja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the good work @egallmeier and @philipc2
minor comment inline for data inspection before operation
erogluorhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me; thanks a lot for all the great efforts @egallmeier and @philipc2 !
Only a couple things:
calculus.ipynblooks like a leftover that should probably be removed- Re new MPAS data and grid files for the gradients test (i.e. "subset" ones): are thopse subsets of existing files we have? Is the subsetting procedure complex that should not be in the testing script? I am trying to understand if we should really add them or generate on the fly.
|
Thanks for the reviews @rajeeja and @erogluorhan
The grids are a subset of a Generating them on the fly would require us to load the entire original grid, which I'd prefer to avoid for our testing. |
|
Depending on whether |
I will be removing that notebook. |
erogluorhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Closes #1299
Overview
UxDataArray.gradient()operator, which computes the zonal and meridional gradients