avoid duplicate 'two' dimensions #1333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1332
Maybe related to issue #1189
Avoid xarray UserWarnings like
Overview
Don't rename size-2 dimensions in io/_ugrid.py.
The original renaming logic might reflect MPAS's convention of naming dimensions of size 2 'TWO'. While this assumption may hold for MPAS-generated files, it causes dimension name collisions when reading other valid UGRID-compliant files (e.g., SCRIP) that use multiple, descriptively-named dimensions of size 2, like
lon_latandmin_max.PR Checklist
General
Testing