Skip to content

Conversation

@ahijevyc
Copy link
Collaborator

@ahijevyc ahijevyc commented Aug 6, 2025

This came up when dealing with #1332.

The dimension lon_lat should be named lat_lon because latitude is in the zero-index and longitude is in the one-index.
This is analogous to how the min_max dimension contains the minimum value in the zero-index and maximum value in the one-index. You wouldn't want to have a dimension name like max_min because min comes first.

Overview

rename dimension lon_lat -> lat_lon because the latitude index comes before longitude.

After tracing the way bounds_array is constructed in _populate_face_bounds it is likely that latitude comes first and longitude comes second. That's why it should be renamed.

All the other variables with lat and lon in their names seems to be consistent with the order of lat and lon in their data.

@ahijevyc ahijevyc marked this pull request as ready for review August 6, 2025 20:50
@ahijevyc ahijevyc requested a review from philipc2 August 6, 2025 20:50
@rajeeja rajeeja self-requested a review August 7, 2025 05:40
Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@philipc2 philipc2 merged commit b70576f into UXARRAY:main Aug 7, 2025
20 checks passed
@ahijevyc ahijevyc deleted the ahijevyc/dim-name-lat_lon branch August 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants