dimension name should be lat_lon because lat comes before lon #1334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up when dealing with #1332.
The dimension
lon_latshould be namedlat_lonbecause latitude is in the zero-index and longitude is in the one-index.This is analogous to how the
min_maxdimension contains the minimum value in the zero-index and maximum value in the one-index. You wouldn't want to have a dimension name likemax_minbecause min comes first.Overview
rename dimension
lon_lat->lat_lonbecause the latitude index comes before longitude.After tracing the way
bounds_arrayis constructed in_populate_face_boundsit is likely that latitude comes first and longitude comes second. That's why it should be renamed.All the other variables with lat and lon in their names seems to be consistent with the order of lat and lon in their data.