Skip to content

Conversation

@philipc2
Copy link
Member

Overview

  • Adds a warning when a user provides a projection to to_polycollection() and to_linecollection() calls.
  • Updates logic to prevent duplicate projection arguments from being passed in, which caused errors

@philipc2 philipc2 self-assigned this Aug 27, 2025
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! See my simple change requests.

@philipc2 philipc2 requested a review from erogluorhan August 27, 2025 23:20
@philipc2
Copy link
Member Author

@erogluorhan

I think the updated warning should be much more informative now. Let me know what you think.

Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@philipc2 philipc2 merged commit a09e0fb into main Aug 29, 2025
15 checks passed
@erogluorhan erogluorhan deleted the pc-fix branch September 26, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants