Skip to content

Curl #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rajeeja merged 12 commits into from
Nov 4, 2025
Merged

Curl #1389

rajeeja merged 12 commits into from
Nov 4, 2025

Conversation

@rajeeja
Copy link
Contributor

@rajeeja rajeeja commented Oct 20, 2025 •
edited by erogluorhan
Loading

Closes #935. Closes #1300.

@review-notebook-app
Copy link

review-notebook-app bot commented Oct 20, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@rajeeja rajeeja changed the title Curl Draft: Curl Oct 23, 2025
@rajeeja
Add comprehensive curl tests and update curl notebook
c411da6 
- Add test_curl_comprehensive.py with extensive curl test coverage
- Update curl.ipynb following divergence notebook pattern
- Remove separate test_curl.py and test_gradient.py files
- All curl functionality tested and working
@rajeeja
Merge main branch
0684868 
- Resolved conflicts in docs/userguide.rst to include both curl and divergence
- Kept curl method implementation in uxarray/core/dataarray.py
- Now have consolidated test_vector_calculus.py from main with gradient and divergence tests
@rajeeja
o Add curl tests to consolidated test_vector_calculus.py
0a9d09a
@rajeeja rajeeja changed the title Draft: Curl Curl Oct 27, 2025
@rajeeja rajeeja requested a review from erogluorhan October 27, 2025 19:42
erogluorhan
erogluorhan approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great; thank you! Only thing I have to say is that can we come up with a simple visualization example for Curl and Divergence, maybe using the gradient data that gradient user guide used before?

@erogluorhan erogluorhan self-requested a review October 30, 2025 17:53
@rajeeja
Copy link
Contributor Author

rajeeja commented Oct 31, 2025

This looks great; thank you! Only thing I have to say is that can we come up with a simple visualization example for Curl and Divergence, maybe using the gradient data that gradient user guide used before?

How about in this PR make only one notebook vector_calculus.ipynb combine gradients/div/curl?

@erogluorhan
Copy link
Member

erogluorhan commented Oct 31, 2025

This looks great; thank you! Only thing I have to say is that can we come up with a simple visualization example for Curl and Divergence, maybe using the gradient data that gradient user guide used before?

How about in this PR make only one notebook vector_calculus.ipynb combine gradients/div/curl?

Yes, that makes sense to me!

erogluorhan
erogluorhan reviewed Nov 3, 2025
View reviewed changes
erogluorhan
erogluorhan reviewed Nov 4, 2025
View reviewed changes
erogluorhan
erogluorhan reviewed Nov 4, 2025
View reviewed changes
@rajeeja rajeeja merged commit aed67b2 into main Nov 4, 2025
13 checks passed
@erogluorhan erogluorhan deleted the rajeeja/vector_calc_curl branch November 21, 2025 21:30
@rljacob rljacob added this to the Calculus Operators milestone Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erogluorhan erogluorhan erogluorhan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Calculus Operators

Development

Successfully merging this pull request may close these issues.

Vector Calculus Operators Add Curl

4 participants

@rajeeja @erogluorhan @rljacob