Skip to content

Conversation

@erogluorhan
Copy link
Member

@erogluorhan erogluorhan commented Oct 30, 2025

Closes #1395

Overview

Adds a link checker into the CI workflow.

Also fix a broken URL in one of the notebooks.

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview

@erogluorhan erogluorhan requested a review from rajeeja October 30, 2025 17:05
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@erogluorhan erogluorhan added documentation Improvements or additions to documentation CI Continuous Integration labels Oct 30, 2025
Copy link
Contributor

@rajeeja rajeeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry the timeout of 60 min is too long?

@erogluorhan
Copy link
Member Author

I worry the timeout of 60 min is too long?

Yeah, maybe. Since it was going to involve docs generation, I wanted to be safe, but now I reduced it to 15 mins. Let's see how it will go with that, and then we can make a decision.

@erogluorhan erogluorhan requested a review from rajeeja November 3, 2025 18:19
@erogluorhan
Copy link
Member Author

I worry the timeout of 60 min is too long?

Yeah, maybe. Since it was going to involve docs generation, I wanted to be safe, but now I reduced it to 15 mins. Let's see how it will go with that, and then we can make a decision.

@rajeeja

Currently, it takes slightly less than 15 mins; hence, I set it to 20 mins for now.

Also, link checker finds two 404s for the time being, but that is because the UXarray docs pages those URLs were attempting to point were never generated (user API entries for ball tree and kd-tree). This PR added those two entries, so once it is merged, those broken links are expected to be fixed since pages will be live. We will need to approve with them (if there is no other issue with this PR)

Feel free to give a review.

Copy link
Contributor

@rajeeja rajeeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is the great! Thank you so much!

@erogluorhan erogluorhan merged commit ace03d8 into main Nov 3, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI needs a link checker addition

3 participants