-
Notifications
You must be signed in to change notification settings - Fork 45
Add a link checker into CI #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
rajeeja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry the timeout of 60 min is too long?
Yeah, maybe. Since it was going to involve docs generation, I wanted to be safe, but now I reduced it to 15 mins. Let's see how it will go with that, and then we can make a decision. |
Currently, it takes slightly less than 15 mins; hence, I set it to 20 mins for now. Also, link checker finds two 404s for the time being, but that is because the UXarray docs pages those URLs were attempting to point were never generated (user API entries for ball tree and kd-tree). This PR added those two entries, so once it is merged, those broken links are expected to be fixed since pages will be live. We will need to approve with them (if there is no other issue with this PR) Feel free to give a review. |
rajeeja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is the great! Thank you so much!
Closes #1395
Overview
Adds a link checker into the CI workflow.
Also fix a broken URL in one of the notebooks.
PR Checklist
General