-
Notifications
You must be signed in to change notification settings - Fork 45
Remapping Code Coverage, Modularize Reused Code, and Documentation Updates #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ahijevyc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch from ux.open_dataset to ux.open_grid where possible, replacing destination_dataset.uxgrid with destination_grid afterwards.
Can we avoid hard-coding reconstruct=True when getting the Ball Tree?
This probably needs to wait for Grid.get_ball_tree to be enhanced.
ahijevyc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great switch to open_grid. Thanks for looking into necessity of reconstruct=True
Closes #963 #924
Overview
Adds tests to get a more complete code coverage. Takes reused code from
nearest_neighborandinverse_distanceand creates one general function for them to call, this should cut down on code and make it easier to create new remapping functions. Updates documentation so the remapping functions are consistent with each other. Also fixes a bug I found when trying to switch from cartesian or spherical after performing one remap.PR Checklist
General
Testing
Documentation
_) and have been added todocs/internal_api/index.rstdocs/user_api/index.rst