REPLACE S3 storage from cloud AWS to self-hosted minIO #26
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
There was a problem hiding this comment.
CRITICAL: Missing function export
generateS3PutPresignedUrl is still imported and used in analysisController.js:131 but was removed from exports. This will cause runtime errors.
export const generateS3PutPresignedUrl = async (key) => {
const command = new PutObjectCommand({
Bucket: process.env.S3_BUCKET,
Key: key,
ContentType: 'video/mp4',
});
const analysisEntryPutPresignedUrl = await getSignedUrl(s3client, command, {
expiresIn: 60 * 90, // 90 minute expiration
});
return analysisEntryPutPresignedUrl;
};
There was a problem hiding this comment.
http://localhost:9000 is hardcoded instead of being configurable via environment variables. This prevents deployment in different environments.
export const s3client = new S3Client({
region: process.env.S3_REGION, // irrelevant since miniIO doesnt takei into account
endpoint: process.env.MINIO_ENDPOINT || 'http://localhost:9000', // Container network endpoint
forcePathStyle: true, // Required for MinIO path-style URLs
credentials: {
accessKeyId: process.env.MINIO_ROOT_USER,
secretAccessKey: process.env.MINIO_ROOT_PASSWORD,
},
});
There was a problem hiding this comment.
The server service is commented out in the Docker Compose file, which will break the development environment. Uncomment it to restore full functionality.
server:
container_name: server
build:
context: .
dockerfile: Dockerfile.dev
environment:
NODE_ENV: ${NODE_ENV}
DEPLOY_ENVIRONMENT: ${DEPLOY_ENVIRONMENT}
POSTHOG_API_KEY: ${POSTHOG_API_KEY}
SESSION_SECRET: ${SESSION_SECRET}
BREVO_API_KEY: ${BREVO_API_KEY}
PRISMA_POSTGRES_DIRECT_URL: ${PRISMA_POSTGRES_DIRECT_URL}
PRISMA_POSTGRES_CONNECTION_STRING: ${PRISMA_POSTGRES_CONNECTION_STRING}
TELEGRAM_BOT_API_KEY: ${TELEGRAM_BOT_API_KEY}
FRONT_WEB_APP_ORIGIN_URL: ${FRONT_WEB_APP_ORIGIN_URL}
STRIPE_API_KEY: ${STRIPE_API_KEY}
STRIPE_WEBHOOK_SECRET: ${STRIPE_WEBHOOK_SECRET}
PORT: ${PORT}
AWS_ACCESS_KEY_ID: ${AWS_ACCESS_KEY_ID}
AWS_SECRET_ACCESS_KEY: ${AWS_SECRET_ACCESS_KEY}
S3_BUCKET: dev-analysis-entry-storage
S3_REGION: ${S3_REGION}
ports:
- 3000:3000
develop:
watch:
- path: .
action: sync+restart #* Synchronize code changes and restart the server
target: /usr/src/app/
depends_on: #* References the SERVICE name - NOT the container_name
database:
condition: service_started
minio:
condition: service_started
networks:
- uxcaptain-network
There was a problem hiding this comment.
💡 SUGGESTION: Clean up deprecated AWS variables
The old AWS environment variables (AWS_SECRET_ACCESS_KEY, AWS_ACCESS_KEY_ID) are still in .env.example but no longer used. Remove them to avoid confusion.
NODE_ENV=development
DEPLOY_ENVIRONMENT=
POSTHOG_API_KEY=
SESSION_SECRET=
BREVO_API_KEY=
PRISMA_POSTGRES_DIRECT_URL=
PRISMA_POSTGRES_CONNECTION_STRING=
TELEGRAM_BOT_API_KEY=
FRONT_WEB_APP_ORIGIN_URL=
STRIPE_API_KEY=
STRIPE_WEBHOOK_SECRET=
PORT=3000
S3_REGION=
S3_BUCKET=
TRANSCRIPTION_ENABLED=
MINIO_ROOT_USER=
MINIO_ROOT_PASSWORD=
MINIO_ENDPOINT=
|
| Severity | Issue | Location |
|---|---|---|
| CRITICAL | Missing function import breaking participant flow | server/controllers/analysisEntryController.js |
| WARNING | Server container commented out in compose.yaml | compose.yaml:1 |
| WARNING | Hardcoded volume path for MinIO storage | compose.yaml:28 |
Recommendation: Address critical issue before merge - participant uploads will fail
Review Details (6 files)
Files: .env.example, .kilocode/rules/memory-bank/tech.md, compose.yaml, server/controllers/analysisEntryController.js, server/integrations/aws/ server/integrations/aws/s3.jsTranscribe.js,
Checked: Security, bugs, performance, error handling
These are being used in AWS Transcribe - this is intentional |
This is intentional - it is a placeholder for the compose file |
This is incorrect - it is being exported correctly |
updated to be used as an env variable |
1 participant
Description
Deprecated the usage of AWS S3 in favor of a locally hosted S3 solution.
The purpose of this change is to optimise costs (due to the extreme costs of AWS provided solutions - specially AWS Transcribe) and to prepare for the upcoming local transcription feature
With cloud hosted, there is always a concern of credentials being leaked and racking up a nonsensical bill
Types of Changes
Related issue
Explanation of changes/Implementation
The S3 client has been updated to include the config for locally hosted minIO instead of previously-used AWS
The compose file has also been updated to include the minIO service
Screenshots (if applicable)
Pull Request Checklist
Additional Notes