Skip to content

Update RakDotNet.IO and Use .NET Standard 2.1#1

Merged
na-2n merged 3 commits intomasterfrom
enhancement/net-standard
Dec 29, 2021
Merged

Update RakDotNet.IO and Use .NET Standard 2.1#1
na-2n merged 3 commits intomasterfrom
enhancement/net-standard

Conversation

@TheNexusAvenger
Copy link
Member

This pull request:

  • Updates RakDotNet.IO to fix a memory leak found by yuwui.
  • Fixes a missing semicolon in the fix for a similar memory leak to above in HashMap.ToBytes.
  • Fixes a missing reference not covered by a previous refactor.
  • Changes the RakDotNet project to use .NET Standard 2.1 instead of .NET Core 3.1.


<ItemGroup>
<PackageReference Include="Microsoft.Data.Sqlite" Version="3.1.2" />
<PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is required as part of .NET Standard 2.1 since the System.ComponentModel.Annotations.Schema namespace is required, but System.ComponentModel.Annotations is not included in .NET Standard. It is part of .NET Core and .NET though.

@na-2n na-2n merged commit b368ab8 into master Dec 29, 2021
@TheNexusAvenger TheNexusAvenger deleted the enhancement/net-standard branch December 29, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants