Open
Conversation
Owner
|
Hey! You're welcome! :) Adding this makes a lot of sense, thanks for contributing! – I'll check it out this week and follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, I want to start with a thank you for building this in public. I was thrilled to run into this project on X a couple weeks ago, it was a much cleaner and well written version of something I felt I would need to build myself for my small suite of personal projects.
This PR adds the
localhost:5775/create-collectorendpoint. My personal projects are mainly API based that often don't have a JS integration. By adding this endpoint, users can create a collector via API without pulling the JS and leverage the IP lookup functionality.Rust is not my strongest language so please let me know if anything needs to be reformatted or fixed!