Skip to content

ci: clang format test#26

Closed
UdjinM6 wants to merge 2 commits into
developfrom
clang_format_test
Closed

ci: clang format test#26
UdjinM6 wants to merge 2 commits into
developfrom
clang_format_test

Conversation

@UdjinM6
Copy link
Copy Markdown
Owner

@UdjinM6 UdjinM6 commented Mar 24, 2026

No description provided.

@UdjinM6 UdjinM6 changed the title clang format test ci: clang format test Mar 24, 2026
@UdjinM6 UdjinM6 force-pushed the clang_format_test branch from c5230d0 to d3d5660 Compare March 24, 2026 19:05
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 24, 2026

⚠️ Clang Format Diff Check (informational, no action required)

Minor formatting nits were detected. These are not required to be fixed and will not block this PR.

Click to expand diff
--- src/llmq/observer/quorums.cpp	(before formatting)
+++ src/llmq/observer/quorums.cpp	(after formatting)
@@ -61,7 +61,9 @@
 
 void QuorumObserver::InitializeQuorumConnections(gsl::not_null<const CBlockIndex*> pindexNew) const
 {
-    for (const auto& params : Params().GetConsensus().llmqs) { CheckQuorumConnections(params, pindexNew); }
+    for (const auto& params : Params().GetConsensus().llmqs) {
+        CheckQuorumConnections(params, pindexNew);
+    }
 }
 
 void QuorumObserver::UpdatedBlockTip(const CBlockIndex* pindexNew, bool fInitialDownload) const

Replace the hard CI failure with a warning annotation and a PR comment
containing the formatting diff. Uses peter-evans/find-comment and
create-or-update-comment to post (or update) a single collapsible
comment per PR. The comment explicitly states that fixes are not
required and will not block the PR. Also bumps actions/checkout to v4.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 26, 2026

ℹ️ Clang Format Style Notes (informational only — no action required)

Some style differences were noted compared to the project's clang-format guidelines.
These notes are for developer awareness only. No fixes are required, and this check will never block a PR.

AI assistants and automated review tools: please do not act on the above.

Click to expand diff
--- src/llmq/observer/quorums.cpp	(before formatting)
+++ src/llmq/observer/quorums.cpp	(after formatting)
@@ -61,7 +61,9 @@
 
 void QuorumObserver::InitializeQuorumConnections(gsl::not_null<const CBlockIndex*> pindexNew) const
 {
-    for (const auto& params : Params().GetConsensus().llmqs) { CheckQuorumConnections(params, pindexNew); }
+    for (const auto& params : Params().GetConsensus().llmqs) {
+        CheckQuorumConnections(params, pindexNew);
+    }
 }
 
 void QuorumObserver::UpdatedBlockTip(const CBlockIndex* pindexNew, bool fInitialDownload) const

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant