[CURA-12774] Don't chop up lines straddling roofing/normal areas too much#2255
Open
[CURA-12774] Don't chop up lines straddling roofing/normal areas too much#2255
Conversation
We don't have to do the whole simplify thing here, since all points will be on a single line anyway -- maybe this is too big (I'd argue not, since this _is_ what the user asked for, though maybe you could say 'inter'line isn't the same), but _just_ using the 'any points within 5 micron are the same' rule here is not even close to enough to prevent zits. done as part of CURA-12774 -- plz test carefully, this might change a bunch of things
This may result in zits in areas that are _just_ on the border between meeting the requirements for top surfaces and normal areas -- of which there may be a lot on certain combinations of curved models and settings. part of CURA-12774
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, this resulted in zits in areas that are just on the border between meeting the requirements for top surfaces and normal areas -- of which there may be a lot on certain combinations of curved models and settings.
I also had to increase the minimum line-length from the absolute minimum 5 micron to the (confusingly named in context) 'maximum resolution' setting. I think this is OK since we don't have to take into account the deviation at all, since we're working with co-linear points most of the time here. This could fix a few things as well -- but it also changes stuff, so test carefully.