Skip to content

Export to slack#24

Open
CoenSchalkwijk wants to merge 3 commits intomasterfrom
export_to_slack
Open

Export to slack#24
CoenSchalkwijk wants to merge 3 commits intomasterfrom
export_to_slack

Conversation

@CoenSchalkwijk
Copy link
Copy Markdown
Contributor

Moved the Jira code to a python module.
Hence the big PR because lots of files have been moved around.

PAGE_SIZE = 50

def __init__(self, api_key: str, api_usr: str) -> None:
self._jira = JIRA("https://ultimaker.atlassian.net/", basic_auth=(api_usr, api_key))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style: Spaces around binary operators.

Suggested change
self._jira = JIRA("https://ultimaker.atlassian.net/", basic_auth=(api_usr, api_key))
self._jira = JIRA("https://ultimaker.atlassian.net/", basic_auth = (api_usr, api_key))

Similar issues exist in the code below as well.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a binary operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants