Skip to content

fix: remove return type declarations from Base_Gateway abstract methods #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superdav42 merged 1 commit into from
Apr 10, 2026
Merged

fix: remove return type declarations from Base_Gateway abstract methods #779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions inc/gateways/class-base-gateway.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public function __construct($order = null) {
* @param \WP_Ultimo\Checkout\Cart $order The order.
* @return void
*/
public function set_order($order): void {
public function set_order($order) {

if (null === $order) {
return;
Expand Down Expand Up @@ -608,7 +608,7 @@ public function verify_and_complete_payment(int $payment_id): array {
* @param string $gateway_payment_id The gateway payment id.
* @return string
*/
public function get_payment_url_on_gateway($gateway_payment_id): string {
public function get_payment_url_on_gateway($gateway_payment_id) {
unset($gateway_payment_id);
return '';
}
Expand All @@ -623,7 +623,7 @@ public function get_payment_url_on_gateway($gateway_payment_id): string {
* @param string $gateway_subscription_id The gateway subscription id.
* @return string
*/
public function get_subscription_url_on_gateway($gateway_subscription_id): string {
public function get_subscription_url_on_gateway($gateway_subscription_id) {
unset($gateway_subscription_id);
return '';
}
Expand All @@ -638,7 +638,7 @@ public function get_subscription_url_on_gateway($gateway_subscription_id): strin
* @param string $gateway_customer_id The gateway customer id.
* @return string
*/
public function get_customer_url_on_gateway($gateway_customer_id): string {
public function get_customer_url_on_gateway($gateway_customer_id) {
unset($gateway_customer_id);
return '';
}
Expand Down Expand Up @@ -853,7 +853,7 @@ public function get_webhook_listener_url() {
* @param \WP_Ultimo\Models\Payment $payment The payment.
* @return void
*/
public function set_payment($payment): void {
public function set_payment($payment) {

$this->payment = $payment;
}
Expand All @@ -865,7 +865,7 @@ public function set_payment($payment): void {
* @param \WP_Ultimo\Models\Membership $membership The membership.
* @return void
*/
public function set_membership($membership): void {
public function set_membership($membership) {

$this->membership = $membership;
}
Expand All @@ -877,7 +877,7 @@ public function set_membership($membership): void {
* @param \WP_Ultimo\Models\Customer $customer The customer.
* @return void
*/
public function set_customer($customer): void {
public function set_customer($customer) {

$this->customer = $customer;
}
Expand All @@ -891,7 +891,7 @@ public function set_customer($customer): void {
* @param \WP_Ultimo\Models\Membership $membership The membership object.
* @return void
*/
public function trigger_payment_processed($payment, $membership = null): void {
public function trigger_payment_processed($payment, $membership = null) {

if (null === $membership) {
$membership = $payment->get_membership();
Expand Down
Loading