Skip to content
This repository was archived by the owner on Dec 15, 2024. It is now read-only.

Conversation

@ert78gb
Copy link
Member

@ert78gb ert78gb commented Nov 19, 2024

closes: UltimateHackingKeyboard/agent#2417

Bump the bundled firmware to uhk-firmware-80-11.2.0-d20ce60

@ert78gb ert78gb requested a review from mondalaci November 19, 2024 22:04
@mondalaci
Copy link
Member

@mhantsch Please test https://github.com/UltimateHackingKeyboard/agent80/actions/runs/11922603382 to update your dongle firmware. Works for me.

@mhantsch
Copy link

Yes, that build got the Dongle firmware updated, and now I got asked to pair it. The Dongle now works again.

image

Three observations:

  1. Before the firmware was updated, the Dongle was not displayed in the firmware update screen. I had to press "Flash firmware (bundled with Agent)", and only during the firmware upgrade process there was a message in the log that gave a hint that it actually found a Dongle and was going to do a firmware upgrade. After the upgrade, it is now listed on the firmware upgrade screen, even if I start Agent only with the keyboard connected, and the plug in the Dongle later. ✔️

  2. The main keymap screen in Agent displays all modules that are currently connected, and also whether the halves are joined. It would seem logical to me to also show any detected Dongle. This should also differentiate between the Dongle being also (wirelessly) connected to the UHK or only to the USB bus of the host.

image

  1. I renamed the Dongle in Agent to "Dongle UHK80 Max" and saved the change. When I then unplugged the USB cable from the keyboard, it would not connect to the Dongle. It would just sit there, displaying "Disconnected". I had to restart the right half to get it to connect to the Dongle again. I am not 100% sure whether that has to do with the renaming. I will continue to observe.

@mhantsch
Copy link

One more observation:

  • disconnect Dongle.
  • connect UHK80 via USB.
  • start Agent.
  • firmware upgrade screen does not show any Dongle (ok).
  • connect Dongle.
  • firmware upgrade screen now shows a Dongle (ok).
  • stay on the firmware upgrade screen and disconnect USB.
  • Agent now shows a leftover bit of the previous screen ("Right keyboard half firmware:") (not quite right).
    image
  • connect USB to UHK again.
  • Agent now does not show the Dongle anymore, but it's still plugged in (not correct).
  • if you unplug and replug the Dongle now, it will appear again.

@mondalaci
Copy link
Member

  1. For me, the firmware update screen always showed the dongle's presence. I think this issue is related to the old firmware version you were running on your dongle. What do you think, @ert78gb?
  2. Showing the connection type can be useful, but for now, Agent can only connect Agent via USB, so I'd implement this later.
  3. This seems like a firmware issue unrelated to Agent or the dongle's name. Do you agree, @kareltucek?

@kareltucek
Copy link
Contributor

  1. This seems like a firmware issue unrelated to Agent or the dongle's name. Do you agree, @kareltucek?

Yes.

@mhantsch
Copy link

2. Showing the connection type can be useful, but for now, Agent can only connect Agent via USB, so I'd implement this later.

This is not about how Agent is connected to the UHK, but to show whether Agent detected a Dongle (connected to the Host USB), and then also to show whether the Dongle has a connection to the UHK or not. Here I am assuming that when the UHK is connected both to Dongle and to USB, Agent will still talk to UHK via USB (USB taking priority over Dongle connection). Or does the USB not establish a Dongle connection at all as long as it is connected to USB? I was under the impression it would connect to both simultaneously, but still route all host communication over USB both for Agent communication and for keyboard and mouse reports.

Hope I am making sense with my writing.

@mondalaci
Copy link
Member

USB should be preferred for Agent communication whenever available, indeed. Other than that, connection priorities will be respected according to the order of host connections, which the current firmware does not yet respect.

As for showing the presence of USB-connected dongles, we should first ask the question, what's its use? We should also ask whether it'd introduce any confusion. I don't think showing dongle presence is useful. Agent already handles pairing gracefully whenever they're connected, and I can't think of another useful use case. It could, however, introduce confusion when a dongle is connected to an external laptop, it's paired with the UHK, and it's not shown because a different wireless connection is active.

@ert78gb
Copy link
Member Author

ert78gb commented Nov 20, 2024

For me, the firmware update screen always showed the dongle's presence. I think this issue is related to the old firmware version you were running on your dongle. What do you think, @ert78gb?

I also think it is old firmware related issue. I haven't experienced it

@mondalaci mondalaci merged commit 0280cc5 into master Nov 20, 2024
3 checks passed
@mondalaci mondalaci deleted the feat-dongle-firmware-upgrade-screen branch November 20, 2024 20:31
@mhantsch
Copy link

We should also ask whether it'd introduce any confusion. I don't think showing dongle presence is useful.

You are right, maybe I hadn't thought this through fully. I'm a bit distracted this week, trying to handle a million things.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dongle firmware update

5 participants