-
Notifications
You must be signed in to change notification settings - Fork 71
Firngrod/primary from same half #1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firngrod/primary from same half #1393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job overall, just a couple of questions and suggestions :-).
…for isPrimary/isSecondary
|
Just to give you an update: I am still very interested in trying out these changes. I am a heavy user of homerow-mods and am very curious how they work out for me. Maybe I can then also provide some newer suggestions on the naming of the keywords. Unfortunately, my UHK80 was returned to UGL as part of a recall, so I have to wait to receive a new keyboard again. Due to holidays season, it will most likely be until at least middle of January before I can try out any newer firmware. |
|
Sorry about leaving this hanging for so long. Life has been keeping me very busy this last week. I will get around to it soon, I promise(tm) |
f38fd11 to
5c50e5f
Compare
kareltucek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I did try my best to keep to the repository guidelines. Let me know if anything is out of place.
I elected not to make it exclusive to advanced strategy as it could also be useful for simple strategy.