Skip to content

Conversation

@firngrod
Copy link
Contributor

What the title says, essentially.

I haven't explicitly tested this on it's own, only on top of the same half stuff, but it should be okay.

@firngrod firngrod marked this pull request as ready for review November 28, 2025 21:07
Copy link
Collaborator

@kareltucek kareltucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just please commit that one grammar suggestion and confirm whether I can merge it. (I will do so against a staging branch. I am more concerned about not creating conflicts against your workflow.)

return SecondaryRoleState_DontKnowYet;
}
KEY_TIMING2(actionKeyWasReleasedButDualkeyNot, KeyTiming_RecordComment(resolutionKey, "SG"));
KEY_TIMING2(actionKeyWasReleasedFirst, KeyTiming_RecordComment(resolutionKey, "SH"));
Copy link
Collaborator

@kareltucek kareltucek Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have told you about these earlier.

This code along with a macro switch and a shell script allows you to capture a timing log and draw an svg graph out of it.

Haven't used it in ages and give no guarantees about the state it is in (it is a very improvised thing that can bring more trouble than benefit)... but just so that you know what it is for and that it exists.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it was something like that. By the way, I haven't kept those up to date in the other PR. Maybe I should update the macros and add the missing ones.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine. The next person who needs it will have to revise the code anyways, so feel free to ignore them 🤷.

Co-authored-by: Karel Tuček <kareltucek@users.noreply.github.com>
@firngrod
Copy link
Contributor Author

If it creates conflicts with my other PRs, I will fix that.

@kareltucek kareltucek changed the base branch from master to hrm November 30, 2025 14:20
@kareltucek kareltucek merged commit 4bcb313 into UltimateHackingKeyboard:hrm Nov 30, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants