-
Notifications
You must be signed in to change notification settings - Fork 71
Finrgrod/Secondary role minimum hold time #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finrgrod/Secondary role minimum hold time #1394
Conversation
…gger as secondary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just please commit that one grammar suggestion and confirm whether I can merge it. (I will do so against a staging branch. I am more concerned about not creating conflicts against your workflow.)
| return SecondaryRoleState_DontKnowYet; | ||
| } | ||
| KEY_TIMING2(actionKeyWasReleasedButDualkeyNot, KeyTiming_RecordComment(resolutionKey, "SG")); | ||
| KEY_TIMING2(actionKeyWasReleasedFirst, KeyTiming_RecordComment(resolutionKey, "SH")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have told you about these earlier.
This code along with a macro switch and a shell script allows you to capture a timing log and draw an svg graph out of it.
Haven't used it in ages and give no guarantees about the state it is in (it is a very improvised thing that can bring more trouble than benefit)... but just so that you know what it is for and that it exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured it was something like that. By the way, I haven't kept those up to date in the other PR. Maybe I should update the macros and add the missing ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine. The next person who needs it will have to revise the code anyways, so feel free to ignore them 🤷.
Co-authored-by: Karel Tuček <kareltucek@users.noreply.github.com>
|
If it creates conflicts with my other PRs, I will fix that. |
What the title says, essentially.
I haven't explicitly tested this on it's own, only on top of the same half stuff, but it should be okay.