Refactor: Improve tick and label sharing logic #373
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a major refactoring of the tick and label sharing mechanism in UltraPlot. The previous implementation had complex and distributed logic for determining tick and label visibility, which was difficult to maintain and extend. This refactoring centralizes the logic within the `Figure` class, making it more robust and easier to understand. Key changes: - A new `_share_ticklabels` method in `Figure` now handles all tick label sharing. - The `_get_border_axes` method has been improved to be more accurate. - The `_Crawler` utility in `ultraplot/utils.py` has been rewritten to better handle complex layouts with panels and mixed axes types. - Redundant and complex logic has been removed from `CartesianAxes`, `GeoAxes`, and other modules.
for more information, see https://pre-commit.ci
beckermr
reviewed
Oct 22, 2025
| return row1, row2, col1, col2 | ||
|
|
||
| def _get_grid_span(self, hidden=False) -> (int, int, int, int): | ||
| def _get_grid_span(self, hidden=True) -> (int, int, int, int): |
Collaborator
There was a problem hiding this comment.
Why did this default change?
beckermr
requested changes
Oct 22, 2025
Collaborator
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
One question. Also there are other PRs that depend on this one and so it may be best to merge this first. Finally, the image comparison tests are failing.
Collaborator
|
I looked at some of the test failures and they definitely need to be fixed in some cases. |
Collaborator
Author
|
This PR is not needed anymore after #372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a major refactoring of the tick and label sharing mechanism in UltraPlot.
The previous implementation had complex and distributed logic for determining tick and label visibility, which was difficult to maintain and extend. This refactoring centralizes the logic within the
Figureclass, making it more robust and easier to understand.Key changes:
_share_ticklabelsmethod inFigurenow handles all tick label sharing._get_border_axesmethod has been improved to be more accurate._Crawlerutility inultraplot/utils.pyhas been rewritten to better handle complex layouts with panels and mixed axes types.CartesianAxes,GeoAxes, and other modules.