Skip to content

CI: remove redundant pytest run #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvanelteren merged 3 commits into from
Jan 26, 2026
Merged

CI: remove redundant pytest run #509

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bac2731
CI: make baseline comparison non-blocking
cvanelteren Jan 26, 2026
38eaa30
CI: drop redundant pytest run
cvanelteren Jan 26, 2026
6a9aba5
Merge branch 'main' into ci-remove-redundant-tests
cvanelteren Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions .github/workflows/build-ultraplot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,38 +52,6 @@ jobs:
run: |
pip install --no-build-isolation --no-deps .

- name: Test Ultraplot
run: |
status=0
filter_nodeids() {
local filtered=""
for nodeid in ${TEST_NODEIDS}; do
local path="${nodeid%%::*}"
if [ -f "$path" ]; then
filtered="${filtered} ${nodeid}"
fi
done
echo "${filtered}"
}
if [ "${TEST_MODE}" = "selected" ] && [ -n "${TEST_NODEIDS}" ]; then
FILTERED_NODEIDS="$(filter_nodeids)"
if [ -z "${FILTERED_NODEIDS}" ]; then
echo "No valid nodeids found; running full suite."
pytest -q --tb=short --disable-warnings -n 0 ultraplot || status=$?
else
pytest -q --tb=short --disable-warnings -n 0 ${FILTERED_NODEIDS} || status=$?
if [ "$status" -eq 4 ] || [ "$status" -eq 5 ]; then
echo "No tests collected from selected nodeids; running full suite."
status=0
pytest -q --tb=short --disable-warnings -n 0 ultraplot || status=$?
fi
fi
else
pytest -q --tb=short --disable-warnings -n 0 ultraplot || status=$?
fi
echo "Final test status: ${status}"
exit "$status"

compare-baseline:
name: Compare baseline Python ${{ inputs.python-version }} with MPL ${{ inputs.matplotlib-version }}
runs-on: ubuntu-latest
Expand Down