Fixed VisVis PyQt4 compatibility and VisVis line properties#54
Open
JarrettR wants to merge 4 commits intoUmSenhorQualquer:masterfrom
JarrettR:master
Open
Fixed VisVis PyQt4 compatibility and VisVis line properties#54JarrettR wants to merge 4 commits intoUmSenhorQualquer:masterfrom JarrettR:master
JarrettR wants to merge 4 commits intoUmSenhorQualquer:masterfrom
JarrettR:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes second and third points in issue #53 .
Does not do anything with the first point, because I'm unsure how pyconf is intended to be used. I hardcoded
conf.PYFORMS_USE_QT5 = Truein my local copy.Additionally, a new feature allows VisVis Line Properties to be passed along with values, as described here
Some code that tests this feature pulled from my private repo is here:
I may add something similar to one of the examples in a future PR if this is desired.