Fix _check_argument_units for pint __eq__ returning duck array #1398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CartoPy 0.18 started validating scales for NaturalEarthFeature, which breaks with the scales for our own map features. There's really no reason to inherit from NaturalEarthFeature, so just make this inherit Feature and add a few missing things.
Matplotlib (as of 3.2.2) does not properly clip text to paths. For now, add a clipbox for the Axes bounding box, which will supplement the set clip path.
0.18 started autoscaling map features and updated some gridline handling, causing changes to our test images.
Matplotlib <3.3 checks for closed contours using floating point equality. For *this test*, this was causing different results on macOS vs. Windows/Linux. Fixing this actually changes the labelling of another closed contour as well.
We were using pytest to catch *and check* a warning coming from numpy, which we no longer get. Just use a simple warning filter since it's not part of *our* API anyway.
This is no longer needed since we're on newer matplotlib versions. Also, now this fixture actually *causes* problems because matplotlib is relying on builtin round returning an int (when not asking for digits), which numpy's does not do.
A few items got deprecated/removed and need updating.
Tripped doc8.
Not sure why this started failing on Travis, but it's only a minor increase. Unable to reproduce locally on a config that should nearly match Travis.
jthielen
added
Type: Bug
Collaborator
Author
|
Closed due to needing to re-create my MetPy fork. See #1425. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny quick fix for hgrecco/pint#1123. No tests or documentation needed to be modified.
Currently dependent on #1372, so leaving as a draft until that gets merged.