Fix xarray support with decode_coords='all' #3664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| def test_ds(request): | ||
| """Provide an xarray dataset for testing.""" | ||
| return xr.open_dataset(get_test_data('narr_example.nc', as_file_obj=False)) | ||
| return xr.open_dataset(get_test_data('narr_example.nc', as_file_obj=False), |
Check warning
Code scanning / CodeQL
File is not always closed
This support was added in pydata/xarray#2844 and handles converting the grid_mapping variable to a coordinate in xarray itself, which was incompatible with some assumptions in parse_cf(). Add some handling for the case where the grid_mapping. Also add decode_coords='all' to our full test suite and adjust a few tests as necessary.
dopplershift
force-pushed
the
xarray-decode
branch
from
a3ae6d6 to
9951000
Compare
dcamron
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This support was added in pydata/xarray#2844 and handles converting the
grid_mappingvariable to a coordinate in xarray itself, which was incompatible with some assumptions inparse_cf(). Add some handling for the case where the grid_mapping. Also adddecode_coords='all'to our full test suite (parametrized) and adjust a few tests as necessary; this includes removing a test for not removinggrid_mappingattribute since that's not a universal truth any more (beyond our control).This is motivated by being compatible with rioxarray, which relies on
decode_coords='all'for its own projection handling, and can be used to load GOES data and do direct image remapping.Checklist