-
Notifications
You must be signed in to change notification settings - Fork 71
Update NCEP TDS data access URLs #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So I wouldn't describe the NCDC links as "new". NCDC (and a few other centers) were renamed to NCEI. I'll also add that the TDS at the NCDC URLs is a few revisions behind that available at NCEI. Having said that, the most important aspect is that the NCDC links actually work. |
dopplershift
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start. Can you fix up the rest of the places where you needed to change the URL that included "grid" to properly use Siphon to read the catalog? That's really best practice anyway and makes use more insulated from changes on the server.
| "ncss = NCSS('https://www.ncei.noaa.gov/thredds/ncss/grid/namanl/'\n", | ||
| "ncss = NCSS('https://www.ncdc.noaa.gov/thredds/ncss//namanl/'\n", | ||
| " '201604/20160416/namanl_218_20160416_1800_000.grb')\n", | ||
| "now = datetime.utcnow()\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line isn't even used, and really doesn't make sense for archived data.
| "source": [ | ||
| "# Open the example netCDF data\n", | ||
| "ncss = NCSS('https://www.ncei.noaa.gov/thredds/ncss/grid/namanl/'\n", | ||
| "ncss = NCSS('https://www.ncdc.noaa.gov/thredds/ncss//namanl/'\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's eliminate the hard-coding of the grid vs. not (which is a thredds server issue) by actually using the catalog. So let's update to something like:
cat = TDSCatalog('https://www.ncdc.noaa.gov/thredds/catalog/namanl/201604/20160416/catalog.xml')
ncss = cat.datasets['namanl_218_20160416_1800_000.grb'].subset()| "\n", | ||
| "And we will use a python package called Siphon to read this data through the NetCDFSubset (NetCDFServer) link.\n", | ||
| "\n", | ||
| "https://www.ncei.noaa.gov/thredds/ncss/grid/narr-a-files/199303/19930313/narr-a_221_19930313_0000_000.grb/dataset.html" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just kill this link.
|
Close in favor of #111 |
Replace the old
ncei.noaa.govTDS URLs I found with their newncdc.noaa.govcounterparts as described in (and closes) #81. Not sure if this is the preferred workflow forpython-trainingor if anything else needs to change to squeeze this in. Let me know!