Skip to content

Conversation

@dcamron
Copy link
Member

@dcamron dcamron commented Mar 5, 2020

Replace the old ncei.noaa.gov TDS URLs I found with their new ncdc.noaa.gov counterparts as described in (and closes) #81. Not sure if this is the preferred workflow for python-training or if anything else needs to change to squeeze this in. Let me know!

@dopplershift
Copy link
Member

So I wouldn't describe the NCDC links as "new". NCDC (and a few other centers) were renamed to NCEI. I'll also add that the TDS at the NCDC URLs is a few revisions behind that available at NCEI.

Having said that, the most important aspect is that the NCDC links actually work.

Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start. Can you fix up the rest of the places where you needed to change the URL that included "grid" to properly use Siphon to read the catalog? That's really best practice anyway and makes use more insulated from changes on the server.

"ncss = NCSS('https://www.ncei.noaa.gov/thredds/ncss/grid/namanl/'\n",
"ncss = NCSS('https://www.ncdc.noaa.gov/thredds/ncss//namanl/'\n",
" '201604/20160416/namanl_218_20160416_1800_000.grb')\n",
"now = datetime.utcnow()\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line isn't even used, and really doesn't make sense for archived data.

"source": [
"# Open the example netCDF data\n",
"ncss = NCSS('https://www.ncei.noaa.gov/thredds/ncss/grid/namanl/'\n",
"ncss = NCSS('https://www.ncdc.noaa.gov/thredds/ncss//namanl/'\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's eliminate the hard-coding of the grid vs. not (which is a thredds server issue) by actually using the catalog. So let's update to something like:

cat = TDSCatalog('https://www.ncdc.noaa.gov/thredds/catalog/namanl/201604/20160416/catalog.xml')
ncss = cat.datasets['namanl_218_20160416_1800_000.grb'].subset()

"\n",
"And we will use a python package called Siphon to read this data through the NetCDFSubset (NetCDFServer) link.\n",
"\n",
"https://www.ncei.noaa.gov/thredds/ncss/grid/narr-a-files/199303/19930313/narr-a_221_19930313_0000_000.grb/dataset.html"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just kill this link.

@dcamron
Copy link
Member Author

dcamron commented Aug 21, 2020

Close in favor of #111

@dcamron dcamron closed this Aug 21, 2020
@dcamron dcamron deleted the ncep-urls branch August 27, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants