Skip to content

fix: more universal unique-signer from Polkadot extension account #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashkuc merged 2 commits into from
Mar 17, 2025
Merged

fix: more universal unique-signer from Polkadot extension account #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
123b993
fix: more universal unique-signer from Polkadot extension account
ashkuc Mar 17, 2025
d8131d8
fix: "sing" -> "sign" typo
ashkuc Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/ExtensionTools/polkadot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ interface Signer {
// Unique SDK types
// =========================================
export interface UNIQUE_SDK_UnsignedTxPayloadBody {
signerPayloadJSON: SignerPayloadJSON
signerPayloadRaw: SignerPayloadRaw
signerPayloadJSON?: SignerPayloadJSON
signerPayloadRaw?: SignerPayloadRaw
signerPayloadHex: string
}

Expand Down Expand Up @@ -285,11 +285,19 @@ const loadWalletByNameSafe = async (walletName: string): Promise<IPolkadotExtens
const signer = {
address,
sign: async (unsignedTxPayload: UNIQUE_SDK_UnsignedTxPayloadBody): Promise<UNIQUE_SDK_SignTxResultResponse> => {
const signatureResult = await signPayload(unsignedTxPayload.signerPayloadJSON)
return {
signatureType: accountType,
signature: signatureResult.signature,
const signatureType = accountType

if (unsignedTxPayload.signerPayloadJSON) {
const {signature} = await signPayload(unsignedTxPayload.signerPayloadJSON)

return {signatureType, signature}
}

const toSign = unsignedTxPayload.signerPayloadRaw || unsignedTxPayload.signerPayloadHex

const {signature} = await signRaw(toSign)

return {signatureType, signature}
}
}

Expand Down