Skip to content

Reduce summarization API to one method#1732

Merged
EgorkaKulikov merged 4 commits intomainfrom
egor/summarization_api
Jan 24, 2023
Merged

Reduce summarization API to one method#1732
EgorkaKulikov merged 4 commits intomainfrom
egor/summarization_api

Conversation

@EgorkaKulikov
Copy link
Copy Markdown
Collaborator

Description

We had two very similar methods in summarization API, and one of them had implicit and long sources analysis.
A unique method with explicit logic is introduced instead of them.

How to test

Automated tests

Our pipeline will do all auomated checks itself.

Manual tests

Standard summaries checks in utbot-plugin.

Self-check list

Check off the item if the statement is true:

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added ctg-refactoring Issue related to refactoring process comp-summaries Something related to the method names, code comments and display names generation labels Jan 23, 2023
@EgorkaKulikov EgorkaKulikov merged commit 1cdc000 into main Jan 24, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/summarization_api branch January 24, 2023 06:13
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-summaries Something related to the method names, code comments and display names generation ctg-refactoring Issue related to refactoring process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants