Merged
Conversation
S1eGa
force-pushed
the
report-sarif
branch
3 times, most recently
from
a9b5efc to
1d6067b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 69.42% 69.71% +0.28%
==========================================
Files 210 216 +6
Lines 30083 30393 +310
Branches 6668 6716 +48
==========================================
+ Hits 20886 21187 +301
+ Misses 6692 6689 -3
- Partials 2505 2517 +12
|
S1eGa
force-pushed
the
report-sarif
branch
5 times, most recently
from
a45b568 to
6fa80e7
Compare
S1eGa
force-pushed
the
report-sarif
branch
7 times, most recently
from
7155494 to
c3ac2ff
Compare
misonijnik
requested changes
Feb 21, 2024
lib/Core/CodeEvents/ReturnEvent.h
Outdated
| @@ -0,0 +1,34 @@ | |||
| #ifndef KLEE_RETURN_EVENT_H | |||
Collaborator
There was a problem hiding this comment.
It might be ok to have declarations of all kinds of events in one header.
Collaborator
Author
There was a problem hiding this comment.
I'll better separate them in different files. With grow number of events single header will be less readable (e.g. Passes.h). I suggest an alternative: use a directory for headers, each consisting of a single class.
| @@ -0,0 +1,76 @@ | |||
| #ifndef KLEE_CODE_LOCATION_H | |||
Collaborator
There was a problem hiding this comment.
We must have a copyright and license block in the head part of all files to match the KLEE project style.
Collaborator
There was a problem hiding this comment.
Add *- C++ -*- for .cpp related headers, please.
lib/Core/Executor.cpp
Outdated
| debugLogBuffer(debugBufferString) { | ||
| debugLogBuffer(debugBufferString), sarifReport({}) { | ||
|
|
||
| // FIXME: put configuration in different place. |
lib/Core/Executor.cpp
Outdated
| baseInBounds = | ||
| AndExpr::create(baseInBounds, mo->getBoundsCheckPointer(base, size)); | ||
| } | ||
| // if (base != address || size != bytes) { |
| // RUN: %clang -emit-llvm -g -c %s -o %t.bc | ||
| // RUN: rm -rf %t.klee-out | ||
| // RUN: %klee -write-sarifs --use-sym-size-alloc --use-sym-size-li --skip-not-symbolic-objects --posix-runtime --libc=uclibc -cex-cache-validity-cores --output-dir=%t.klee-out %t.bc > %t.log | ||
| // RUN: python3 %S/../../checker.py %t.klee-out/report.sarif %S/pattern.sarif |
Collaborator
There was a problem hiding this comment.
Add checker.py as a command in lit.cfg
S1eGa
force-pushed
the
report-sarif
branch
2 times, most recently
from
fda377e to
dd98605
Compare
misonijnik
requested changes
Feb 22, 2024
test/SARIF/lit.local.cfg
Outdated
|
|
||
| config.substitutions.append( | ||
| ('%checker', f"python3 {os.path.join(os.path.dirname(__file__), 'checker.py')}".strip()) | ||
| ) No newline at end of file |
| @@ -0,0 +1,76 @@ | |||
| #ifndef KLEE_CODE_LOCATION_H | |||
Collaborator
There was a problem hiding this comment.
Add *- C++ -*- for .cpp related headers, please.
| @@ -0,0 +1,76 @@ | |||
| #ifndef KLEE_CODE_LOCATION_H | |||
* Introduces `CodeEvent` as a base unit for storing information about event in code. * `CodeEvent`s are managed with `EventRecorder`, capable of serializing recorded trace. * `termianateStateOnProgramError` receives an `ErrorEvent` object contatining all required information about error. [feat] Enhances `gepExprBases`: * Bases for addresses stored for constant expressions. * Precalculates bases for `llvm::ConstantExpr` (i.e. for `getElementPtr` in arguments of instructions). [perf] Removes checks on `baseInBounds` during memory operations. [fix] Adds hacks for managing objects with neighboring addresses (in some cases `gepExprBases` could assume that the beginning of one object is the end of another). [fix] Fixes ODR violation with `llvm::APFloat::RoundingMode`.
misonijnik
approved these changes
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR providing support for generating error report in SARIF format.
Adds support for reporting errors in SARIF format:
CodeEventas a base unit for storing information about event in code.CodeEvents are managed withEventRecorder, capable of serializing recorded trace.termianateStateOnProgramErrorreceives anErrorEventobject contatining all required informration about error.Enhances
gepExprBases:llvm::ConstantExpr(i.e. forgetElementPtrin arguments of instructions)Removes checks on
baseInBoundsduring memory operations.Adds hacks for managing objects with neighboring addresses (in some cases
gepExprBasescould fail for that case).Fixes ODR violation with
llvm::APFloat::RoundingMode.