Skip to content

[feat] ObjectManager#173

Merged
misonijnik merged 1 commit intomainfrom
ocelaiwo/object_manager
Mar 7, 2024
Merged

[feat] ObjectManager#173
misonijnik merged 1 commit intomainfrom
ocelaiwo/object_manager

Conversation

@ocelaiwo
Copy link
Collaborator

@ocelaiwo ocelaiwo commented Feb 29, 2024

This pull request introduces the ObjectManager class, an intermediary between the Executor and the components that need to be aware of changes in the execution objects (for now ExecutionStates only).

@ocelaiwo ocelaiwo force-pushed the ocelaiwo/object_manager branch from 5bd5bb7 to d748d26 Compare February 29, 2024 10:21
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Merging #173 (059db80) into main (a5e9de2) will increase coverage by 0.05%.
The diff coverage is 80.09%.

❗ Current head 059db80 differs from pull request most recent head cdbb50d. Consider uploading reports for the commit cdbb50d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   69.76%   69.81%   +0.05%     
==========================================
  Files         219      225       +6     
  Lines       31170    31256      +86     
  Branches     6890     6897       +7     
==========================================
+ Hits        21745    21822      +77     
- Misses       6844     6848       +4     
- Partials     2581     2586       +5     
Files Coverage Δ
lib/Core/BidirectionalSearcher.h 100.00% <100.00%> (ø)
lib/Core/Executor.h 74.07% <ø> (ø)
lib/Core/ObjectManager.h 100.00% <100.00%> (ø)
lib/Core/SearcherUtil.h 100.00% <100.00%> (ø)
lib/Core/StatsTracker.cpp 80.74% <100.00%> (+0.46%) ⬆️
lib/Core/TargetCalculator.h 100.00% <ø> (ø)
lib/Core/TargetManager.h 92.30% <ø> (ø)
lib/Core/TargetedExecutionManager.h 100.00% <ø> (ø)
lib/Core/BidirectionalSearcher.cpp 88.88% <88.88%> (ø)
lib/Core/TargetCalculator.cpp 90.00% <66.66%> (-0.45%) ⬇️
... and 5 more

@ocelaiwo ocelaiwo force-pushed the ocelaiwo/object_manager branch from d748d26 to 8f954a2 Compare March 6, 2024 10:13
@ocelaiwo ocelaiwo force-pushed the ocelaiwo/object_manager branch from 8f954a2 to cdbb50d Compare March 6, 2024 10:15
@ocelaiwo ocelaiwo requested a review from misonijnik March 6, 2024 10:15
@ocelaiwo ocelaiwo marked this pull request as ready for review March 6, 2024 10:17
@misonijnik misonijnik merged commit 905d10f into main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants