Skip to content

Conversation

@hariedo
Copy link
Collaborator

@hariedo hariedo commented Jun 28, 2025

Potential alternative to Issue 58
#58

We have a lot of existing @publishers with no database to associate them with the packageID they published.

Instead of relying on a database of publisher/package IDs, we offer an improved publisher validation email that explains how a real publisher can fight back against spam (if it's happening).

@github-actions
Copy link

🚀 Deploy this PR to an environment

You can deploy this PR to either development or staging environment:

  • Comment /deploy_dev to deploy to the development environment

Alternatively, you can:

  1. Go to Actions tab
  2. Click on "Manual Deploy to Firebase" workflow
  3. Click the "Run workflow" button
  4. Select branch: hariedo-publisher-email-1
  5. Choose environment: DEV
  6. Enter a deployment message
  7. Click "Run workflow"

@deepsource-io
Copy link

deepsource-io bot commented Jun 28, 2025

Here's the code health analysis summary for commits e1653fb..5821e97. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource C# LogoC#✅ Success
❗ 1 occurence introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@SimplyJpk
Copy link
Member

It has never been a problem, just one of those things where it could have become a problem from a malicious user. I think your change is practical, at least gives a user more of an option.

I think it might be a good idea to have a loose restriction per userid/pubid and have a runtime list/dictionary of ids for last time requested, number of times requested and publisher id since we'd have a quick way to confirm activity of the command. (Something similar to the welcome channel protection basically) But that can be added later if we ever have a problem with these emails.

@hariedo hariedo marked this pull request as ready for review June 30, 2025 10:53
@hariedo
Copy link
Collaborator Author

hariedo commented Jun 30, 2025

/deploy_dev

@github-actions
Copy link

🚀 Starting deployment of Unity-Developer-Community/UDC-Bot:hariedo-publisher-email-1 to development...

@hariedo hariedo merged commit edd0e8b into master Jun 30, 2025
8 checks passed
@hariedo hariedo deleted the hariedo-publisher-email-1 branch June 30, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants