-
Notifications
You must be signed in to change notification settings - Fork 9
Refactor birthday feature from Google Sheets to database storage #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
🚀 Deploy this PR to an environmentYou can deploy this PR to either development or staging environment:
Alternatively, you can:
|
Co-authored-by: Pierre-Demessence <1756398+Pierre-Demessence@users.noreply.github.com>
Co-authored-by: Pierre-Demessence <1756398+Pierre-Demessence@users.noreply.github.com>
…s to use database Co-authored-by: Pierre-Demessence <1756398+Pierre-Demessence@users.noreply.github.com>
Co-authored-by: Pierre-Demessence <1756398+Pierre-Demessence@users.noreply.github.com>
|
/deploy_dev |
|
🚀 Starting deployment of |
|
/deploy_dev |
|
🚀 Starting deployment of |
|
A few comments:
|
…ay support Co-authored-by: Pierre-Demessence <1756398+Pierre-Demessence@users.noreply.github.com>
I've implemented all the requested changes: ✅ Slash command group: Added Added a new database method Commit: 9990d0d |
|
/deploy_dev |
|
🚀 Starting deployment of |
This PR completely refactors the birthday feature to use database storage instead of Google Sheets, addressing all requirements from the issue.
Summary of Changes
Database Schema
Birthdaycolumn (nullable datetime) touserstableUpdateBirthday(),GetBirthday(),GetTodaysBirthdays(),GetNextBirthday()New Commands
!setbirthday MM/DD[/YYYY](alias:!setbday) - Allows users to set their birthday!removebirthday(aliases:!removebday,!deletebirthday,!deletebday) - Allows users to remove their birthdayUpdated Existing Commands
!bday- Now retrieves next upcoming birthday from database instead of Google Sheets!bday @user- Now retrieves specific user's birthday from database with improved error messagingService Updates
BirthdayAnnouncementServiceto use database queriesKey Features Implemented
✅ Database storage - No more dependency on Google Sheets
✅ Direct birthday management - Users can add/remove their own birthdays
✅ User mentions in announcements - Announcements now properly mention the birthday user
✅ Backwards compatibility - All existing
!bdayfunctionality preserved✅ Flexible date formats - Supports MM/DD and MM/DD/YYYY formats
Technical Details
Testing
Fixes #335.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
www.myget.orgdotnet build --nologo(dns block)/home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.