Skip to content

Conversation

@Pauliusd01
Copy link
Collaborator

Description

Please fill this section with a description what the pull request is trying to address and what changes were made.

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity:
  • Halo Effect:

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Jan 12, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

Mostly mechanical version bumps plus a manifest dependency update that needs quick validation in CI/Unity.
🏅 Score: 85

Changes look consistent for a version bump, but the `Packages/manifest.json` dependency churn may have unintended compatibility/lockstep impacts without accompanying validation notes/tests.
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Sync

Confirm the bumped kAssemblyVersion and kDocUrl remain in sync with Packages/com.unity.inputsystem/package.json and any other version constants to avoid mismatched runtime reporting and documentation links.

internal const string kAssemblyVersion = "1.18.0";
internal const string kDocUrl = "https://docs.unity3d.com/Packages/com.unity.inputsystem@1.18";
Validation Drift

Ensure the PackageVersion in the API validation exception is intentionally updated and still applies to the same validation baseline; otherwise this could mask real breaking-change detection for 1.18.0.

"PackageVersion": "1.18.0",
"__comments": "starting from 2022.3 ugui is not added to the project by default. We have some APIs that are conditional on ugui being present, so the API Validation thinks we are breaking API, but that is not the case."
Dependency Risk

The manifest updates add/remove/bump several packages (including removal of com.unity.textmeshpro and addition of multiple modules); verify this is intended for the version bump and that sample/tests/projects depending on these packages still import and run without missing-package or compilation issues.

"com.unity.ai.navigation": "2.0.9",
"com.unity.analytics": "3.8.2",
"com.unity.cinemachine": "2.10.5",
"com.unity.coding": "0.1.0-preview.24",
"com.unity.ide.rider": "3.0.38",
"com.unity.ide.visualstudio": "2.0.25",
"com.unity.multiplayer.center": "1.0.1",
"com.unity.settings-manager": "2.1.1",
"com.unity.test-framework": "1.7.0",
"com.unity.test-framework.build": "0.0.1-preview.12",
"com.unity.test-framework.performance": "3.2.0",
"com.unity.test-framework.utp-reporter": "1.1.0-preview",
"com.unity.ugui": "2.0.0",
"nuget.mono-cecil": "1.0.0",
"com.unity.modules.accessibility": "1.0.0",
"com.unity.modules.adaptiveperformance": "1.0.0",
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

@u-pr-agent
Copy link
Contributor

u-pr-agent bot commented Jan 12, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@josepmariapujol-unity
Copy link
Collaborator

Some errors reported by CI:
Project has invalid dependencies:
com.unity.modules.adaptiveperformance: Package [com.unity.modules.adaptiveperformance@1.0.0] cannot be found
com.unity.modules.vectorgraphics: Package [com.unity.modules.vectorgraphics@1.0.0] cannot be found

@Pauliusd01
Copy link
Collaborator Author

Some errors reported by CI: Project has invalid dependencies: com.unity.modules.adaptiveperformance: Package [com.unity.modules.adaptiveperformance@1.0.0] cannot be found com.unity.modules.vectorgraphics: Package [com.unity.modules.vectorgraphics@1.0.0] cannot be found

wtf

@codecov-github-com
Copy link

codecov-github-com bot commented Jan 12, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2320   +/-   ##
========================================
  Coverage    77.95%   77.96%           
========================================
  Files          476      476           
  Lines        97443    97443           
========================================
+ Hits         75961    75967    +6     
+ Misses       21482    21476    -6     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.54% <ø> (ø)
inputsystem_MacOS_2022.3_project 75.47% <ø> (ø)
inputsystem_MacOS_6000.0 5.32% <ø> (ø)
inputsystem_MacOS_6000.0_project 77.36% <ø> (ø)
inputsystem_MacOS_6000.3 5.32% <ø> (ø)
inputsystem_MacOS_6000.3_project 77.36% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.4 5.32% <ø> (ø)
inputsystem_MacOS_6000.4_project 77.36% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.5 5.32% <ø> (ø)
inputsystem_MacOS_6000.5_project 77.37% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_2022.3 5.54% <ø> (ø)
inputsystem_Ubuntu_2022.3_project 75.26% <ø> (ø)
inputsystem_Ubuntu_6000.0 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.0_project 77.17% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.3 5.32% <ø> (ø)
inputsystem_Ubuntu_6000.3_project 77.16% <ø> (ø)
inputsystem_Ubuntu_6000.4 5.33% <ø> (ø)
inputsystem_Ubuntu_6000.4_project 77.17% <ø> (ø)
inputsystem_Ubuntu_6000.5 5.33% <ø> (ø)
inputsystem_Ubuntu_6000.5_project 77.17% <ø> (ø)
inputsystem_Windows_2022.3 5.54% <ø> (ø)
inputsystem_Windows_2022.3_project 75.60% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.0 5.32% <ø> (ø)
inputsystem_Windows_6000.0_project 77.49% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3 5.32% <ø> (ø)
inputsystem_Windows_6000.3_project 77.49% <ø> (+<0.01%) ⬆️
inputsystem_Windows_6000.4 5.32% <ø> (ø)
inputsystem_Windows_6000.4_project 77.49% <ø> (ø)
inputsystem_Windows_6000.5 5.32% <ø> (ø)
inputsystem_Windows_6000.5_project 77.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
Assets/Samples/InGameHints/InGameHintsActions.cs 17.69% <ø> (ø)
...sts/InputSystem/InputActionCodeGeneratorActions.cs 59.49% <ø> (ø)
...em/InputSystem/Devices/Precompiled/FastKeyboard.cs 100.00% <ø> (ø)
...ystem/InputSystem/Devices/Precompiled/FastMouse.cs 100.00% <ø> (ø)
...InputSystem/Devices/Precompiled/FastTouchscreen.cs 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@josepmariapujol-unity josepmariapujol-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pauliusd01 Pauliusd01 merged commit be2449e into develop Jan 12, 2026
107 of 108 checks passed
@Pauliusd01 Pauliusd01 deleted the Bump-version-to-1.18.0 branch January 12, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants