Skip to content

Add OnBeforeDisposeVolatileData method #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brnkhy wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −0
Open

Add OnBeforeDisposeVolatileData method #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b6717a
add OnBeforeDisposeVolatileData virtual method
brnkhy Mar 19, 2026
1e82934
remove dictionary parameter
brnkhy Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Packages/com.unity.cloud.gltfast/Runtime/Scripts/GltfImport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3086,11 +3086,19 @@ static string GetUniqueNodeName(RootBase gltf, uint index, ICollection<string> e
return name;
}

/// <summary>
/// Called at the beginning of <see cref="DisposeVolatileData"/> before buffers are freed.
/// Override to process data while it is still accessible.
/// </summary>
protected virtual void OnBeforeDisposeVolatileData() { }

/// <summary>
/// Free up volatile loading resources
/// </summary>
async Task DisposeVolatileData()
{
OnBeforeDisposeVolatileData();

m_Buffers = null;
m_BinChunks = null;

Expand Down