[MLA-1809] catch mismatched observation sizes #5030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Even though we check and assert on the Unity side, it's possible to get observations of different size send over. This will cause a numpy exception when trying to pack them into an array:
This change adds an extra check that the observations all have the shape of the observation spec:
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://forum.unity.com/threads/walker-demo-adding-blockcontact-observation-valueerror-setting-an-array-element-with-a-sequence.1065587/#post-6895055
Types of change(s)
Checklist