Export mono_debug_domain_create, unload, enabled (as with vanilla)

[0x0ade]

The symbols are public on non-Windows platforms and are exported on Windows in vanilla mono: https://github.com/mono/mono/blob/master/msvc/mono.def#L200

Making the symbols public would remove the need for any address hackery and offset guessing on Windows when trying to access it:

    // REPLACE THOSE ADDRESSES WITH THOSE IN THE mono.dll SHIPPING WITH YOUR GAME!
    private static long WINDOWS_f_mono_debug_init = 0x0000000180074cd4;
    private static long WINDOWS_f_mono_debug_domain_create = 0x0000000180074ac0;
    // ...
    public static bool/*-if-it-returns-at-all*/ Force(MonoDebugFormat format = MonoDebugFormat.MONO_DEBUG_FORMAT_MONO) {
    // ...
        if (Environment.OSVersion.Platform == PlatformID.Win32NT) {
            Debug.Log("On Windows, mono_debug_domain_create is not public. Creating delegate from pointer.");
            // The function is not in the export table on Windows... although it should
            // See https://github.com/Unity-Technologies/mono/blob/unity-staging/msvc/mono.def
            // Compare with https://github.com/mono/mono/blob/master/msvc/mono.def, where mono_debug_domain_create is exported
            IntPtr m_mono = GetModuleHandle("mono.dll");
            IntPtr p_mono_debug_init = GetProcAddress(m_mono, "mono_debug_init");
            IntPtr p_mono_debug_domain_create = new IntPtr(WINDOWS_f_mono_debug_domain_create - WINDOWS_f_mono_debug_init + (p_mono_debug_init.ToInt64()));
            mono_debug_domain_create = (d_mono_debug_domain_create) Marshal.GetDelegateForFunctionPointer(p_mono_debug_domain_create, typeof(d_mono_debug_domain_create));

        }

I understand if this pull request gets ignored. Forcing mono into debug mode from managed space is quite unstable and unsupported.

[joshpeterson]

This change looks fine actually, we should be able expose these additional functions without problems.

[joshpeterson]

Actually, I've had to revert this merge at 9036ae8. It looks like mono_debug_enabled does not exist, so the Windows build breaks. Did you intend to expose something else?

[0x0ade]

It's actually the symbol next to mono_debug_domain_unload, so I must've accidentally carried it over from the vanilla mono.def. I'll update my fork accordingly.

I didn't intend to expose anything else. And actually, I didn't expect any response! Thanks for taking a look!

[0x0ade]

I've updated my fork, but GitHub doesn't show the change here as this PR is already "merged". Should I submit a new PR?

[joshpeterson]

Yes, please submit a new PR.