jitdump fixes from upstream #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-zakharov
approved these changes
Mar 26, 2024
alexey-zakharov
left a comment
alexey-zakharov
left a comment
There was a problem hiding this comment.
looks good and matches the upstream PR
question - should we wait for upstream merge in case there are further fixes required?
Author
I'm 99% certain that these are the only remaining functional correctness fixes. Anything else from upstream is just going to be ifdef/cmake shenanigans. I'm going to go ahead and merge this here so that we can get an updated build in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upstreaming the jitdump-on-mac work in dotnet#99986 a few correctness issues were discovered. This adds those changes into our branch. There may be some additional tweaks upstream but they will be largely ifdef etc. related.