feat: add validation for discovery profile URLs#8
Merged
damaz91 merged 2 commits intoUniversal-Commerce-Protocol:mainfrom Jan 21, 2026
Merged
feat: add validation for discovery profile URLs#8damaz91 merged 2 commits intoUniversal-Commerce-Protocol:mainfrom
damaz91 merged 2 commits intoUniversal-Commerce-Protocol:mainfrom
Conversation
Enhances the protocol conformance tests to verify that all documentation and schema URLs provided in the UCP discovery profile are reachable and return valid content. - Added `test_discovery_urls` to `ProtocolTest`. - Implemented `_extract_document_urls` helper to collect URLs with their JSON paths for better debugging. - Validates that `spec`, `schema`, `config_schema`, and `instrument_schemas` fields return 200 OK. - Checks content type validity (parseable JSON or valid HTML). - Reports all broken links in a single failure message with their exact location in the discovery profile.
Contributor
Author
|
Fixes #7 |
wry-ry
approved these changes
Jan 16, 2026
damaz91
approved these changes
Jan 21, 2026
damaz91
merged commit 24928f7
into
Universal-Commerce-Protocol:main
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances the protocol conformance tests to verify that all documentation and schema URLs provided in the UCP discovery profile are reachable and return valid content.
test_discovery_urlstoProtocolTest._extract_document_urlshelper to collect URLs with their JSON paths for better debugging.spec,schema,config_schema, andinstrument_schemasfields return 200 OK.