Skip to content

Canonicalized versions of withSystemTempDirectory and withTempDirectory#2

Closed
robstewart57 wants to merge 2 commits intoUnkindPartition:masterfrom
robstewart57:master
Closed

Canonicalized versions of withSystemTempDirectory and withTempDirectory#2
robstewart57 wants to merge 2 commits intoUnkindPartition:masterfrom
robstewart57:master

Conversation

@robstewart57
Copy link

@robstewart57
Copy link
Author

@feuerbach would you mind pinging me once this commit is reflected as a version bump on hackage, please?

@UnkindPartition
Copy link
Owner

Sure, will do. But could you clarify the docs (as I asked in the other PR)?

Adds documentation to distinguish withSystemTempDirectory and
withCanonicalizedSystemTempDirectory. Also removes
withCanoncalizedTempDirectory, which turns out not to be useful.
@robstewart57
Copy link
Author

Thanks. I've added documentation in 7f0d514 , appended to this PR.

@christian-marie
Copy link

+1 to this PR, I had some tests failing on OSX only because it puts its temp files in a symlinked /var/. Glad this is getting done.

@UnkindPartition
Copy link
Owner

I guess I never got a response from @robstewart57 on my question about withCanonicalizedSystemTempDirectory, and this PR stalled. @christian-marie perhaps you could review the commits and let me know what you think?

@UnkindPartition
Copy link
Owner

@christian-marie also, feel free to prepare your own version with the spaces fixed etc. No need to create a new PR, just point me to your branch here and I'll merge it once we reach a consensus.

@christian-marie
Copy link

Feeling so free to do so, but effort is concentrated elsewhere.

@christian-marie
Copy link

Besides, this need not be a race. @robsteward57 may yet lay claim to this.

@robstewart57
Copy link
Author

Indeed, @robstewart57 may :-)

I'm seeing the emails. Busy today, I'll address tomorrow or Monday.

@UnkindPartition
Copy link
Owner

@robstewart57 starting from v.1.2.1, the system temporary directory (TMPDIR) is canonicalized automatically by all functions that access it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants