GHA - Replace Vercel bash deploy script by "deploy-on-vercel" github action by Demmonius · Pull Request #296 · UnlyEd/next-right-now

Demmonius · 2021-02-23T14:52:39Z

Reduce the complexity of the Vercel deployment script (GitHub Actions) by using a dedicated action instead of the existing bash script.

Makes the code much more readable, remove code duplication (x3) in various actions.

github-actions · 2021-02-23T14:59:57Z

✅ Deployment SUCCESS
Commit d6e28ee successfully deployed to
Deployment aliased as

github-actions · 2021-02-23T15:06:12Z

✅ E2E tests SUCCESS for commit d6e28ee previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-le9gfznxk-unly-oss.vercel.app

Vadorequest · 2021-02-23T15:08:39Z

.github/workflows/deploy-vercel-staging.yml

            CUSTOMER_REF_TO_DEPLOY=${{ env.CUSTOMER_REF_TO_DEPLOY }}
-            VERCEL_DEPLOYMENT_URL=${{ env.VERCEL_DEPLOYMENT_URL }}
            VERCEL_DEPLOYMENT_DOMAIN=${{ env.VERCEL_DEPLOYMENT_DOMAIN }}
+            VERCEL_DEPLOYMENT_URL=${{ format('https://{0}', env.VERCEL_DEPLOYMENT_DOMAIN) }}


Shouldn't the VERCEL_DEPLOYMENT_URL and VERCEL_DEPLOYMENT_DOMAIN both be returned by the Action?

That'd avoid doing the above which isn't dev-friendly

Yes I agree

Vadorequest · 2021-02-23T15:10:29Z

package.json

-    "deploy:ci:gha": "yarn vercel:cleanup && yarn vercel:deploy --local-config=vercel.${CUSTOMER_REF}.staging.json",
-    "deploy:ci:gha:production": "yarn vercel:cleanup && yarn vercel:deploy --local-config=vercel.${CUSTOMER_REF}.production.json --prod",
+    "deploy:ci:gha": "yarn vercel:deploy --local-config=vercel.${CUSTOMER_REF}.staging.json",
+    "deploy:ci:gha:production": "CUSTOMER_REF=${CUSTOMER_REF} yarn vercel:deploy --local-config=vercel.${CUSTOMER_REF}.production.json --prod",


Why CUSTOMER_REF=${CUSTOMER_REF} ? Doesn't seem necessary, and it's confusing because the above command doesn't define it.

Mistake, I removed it from staging but not production

github-actions · 2021-02-24T12:24:09Z

✅ Deployment SUCCESS
Commit fc46206 successfully deployed Storybook static site to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-p5o6y2e1z-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

github-actions · 2021-02-24T12:29:48Z

✅ E2E tests SUCCESS for commit fc46206 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-7u1iwwx5h-unly-oss.vercel.app

github-actions · 2021-02-24T12:29:57Z

✅ E2E tests SUCCESS for commit fc46206 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-p5o6y2e1z-unly-oss.vercel.app

.github/workflows/deploy-vercel-production.yml

.github/workflows/deploy-vercel-staging.yml

.github/workflows/deploy-vercel-storybook.yml

github-actions · 2021-05-04T09:29:52Z

✅ Deployment SUCCESS
Commit ebc9339 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-c1kchq71l-unly-oss.vercel.app
Deployment aliased as

github-actions · 2021-05-04T09:35:27Z

✅ E2E tests SUCCESS for commit ebc9339 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-c1kchq71l-unly-oss.vercel.app

…c24a6429fdd257598df2017 (v1.0.0) instead of latest

github-actions · 2021-05-08T12:07:07Z

✅ Deployment SUCCESS
Commit 145a048 successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-36djmkawr-unly-oss.vercel.app
Deployment aliased as

github-actions · 2021-05-08T12:07:26Z

✅ Deployment SUCCESS
Commit 145a048 successfully deployed Storybook static site to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-cgqfx5fhx-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

github-actions · 2021-05-08T12:11:48Z

✅ E2E tests SUCCESS for commit 145a048 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-cgqfx5fhx-unly-oss.vercel.app

github-actions · 2021-05-08T12:12:23Z

✅ E2E tests SUCCESS for commit 145a048 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-36djmkawr-unly-oss.vercel.app

github-actions · 2021-05-08T12:13:43Z

✅ Deployment SUCCESS
Commit 7cc8a1b successfully deployed to https://nrn-v2-mst-aptd-at-lcz-sty-c1-4ujwkei3y-unly-oss.vercel.app
Deployment aliased as

github-actions · 2021-05-08T12:14:19Z

✅ Deployment SUCCESS
Commit 7cc8a1b successfully deployed Storybook static site to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-1pu42m809-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

github-actions · 2021-05-08T12:19:06Z

✅ E2E tests SUCCESS for commit 7cc8a1b previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-1pu42m809-unly-oss.vercel.app

github-actions · 2021-05-08T12:19:14Z

✅ E2E tests SUCCESS for commit 7cc8a1b previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-4ujwkei3y-unly-oss.vercel.app

…action (#296) Co-authored-by: Dhenain Ambroise <ambroise.dhenain@gmail.com>

Co-authored-by: Dhenain Ambroise <ambroise.dhenain@gmail.com>

Demmonius added 26 commits February 22, 2021 14:22

Updated staging with the new action

e4569c7

Fixed variable providing

4ca6de1

Using action env instead of a long command

d580d66

Installing npx for GHA

e9a78ee

Installing node in the same job to make npx works

4f20a59

Removed job dependency

0bd48c8

Installing npx

184b14b

Manual map npx in PATH

792de6c

Using new method

2a8d24f

Npx debug version

71025f8

Changed node setup version

c4406d7

Not cleaning vercel folder when using GHA

ee2fda5

Trying to export yarn bins

e0b848b

Using whoami to debug action access

2a369d8

who's starting npm scripts

faccc8a

Make sure to install deps

ce970ea

Fixed vercel variable token

71f081c

Fixed vercel token

cd8b1f6

Need token in the command AND the env

42701b1

Updated vercel script used

7cd01d1

Fixed useless variable

4c6b63c

Using echo instead of a real deploy on vercel to debug

be369bf

Fixing debug echo into vercel binary

b685c00

Adapting to use DOMAIN with https

40506da

Moved back staging file

7d6d236

Removed whoami debug

d6e28ee

github-actions bot temporarily deployed to customer1-staging February 23, 2021 14:53 Inactive

Vadorequest requested changes Feb 23, 2021

View reviewed changes

Vadorequest requested changes Mar 3, 2021

View reviewed changes

Vadorequest changed the title ~~Implement own vercel deploy action~~ GHA - Replace Vercel bash deploy script by "deploy-on-vercel" github action Mar 3, 2021

Fixed PR suggestions

ebc9339

github-actions bot temporarily deployed to customer1-staging May 4, 2021 09:21 Inactive

Use UnlyEd/github-action-deploy-on-vercel at commit 3e71d3e26fd56941f…

145a048

…c24a6429fdd257598df2017 (v1.0.0) instead of latest

github-actions bot temporarily deployed to customer1-staging May 8, 2021 11:58 Inactive

github-actions bot temporarily deployed to storybook May 8, 2021 11:58 Inactive

Vadorequest added 2 commits May 8, 2021 14:04

Fix typo in "VERCEl_TOKEN" (lowercase "l")

6632528

Remove "applyDomainAliases" option (because it's true by default)

7cc8a1b

github-actions bot temporarily deployed to storybook May 8, 2021 12:07 Inactive

github-actions bot temporarily deployed to customer1-staging May 8, 2021 12:07 Inactive

Vadorequest marked this pull request as ready for review May 8, 2021 12:30

Vadorequest merged commit 3ec63ac into v2-mst-aptd-at-lcz-sty May 8, 2021

Vadorequest deleted the implement-own-vercel-deploy-action branch May 8, 2021 12:30

Vadorequest added a commit that referenced this pull request May 8, 2021

GHA - Replace Vercel bash deploy script by "deploy-on-vercel" github …

e03b530

…action (#296) Co-authored-by: Dhenain Ambroise <ambroise.dhenain@gmail.com>

Vadorequest added a commit that referenced this pull request May 13, 2021

Fix - Display deployment's aliases on PR (regression from #296) (#318)

eac9b00

Co-authored-by: Dhenain Ambroise <ambroise.dhenain@gmail.com>

Vadorequest added a commit that referenced this pull request May 13, 2021

Fix - Display deployment's aliases on PR (regression from #296) (#318)

bf14a4b

Co-authored-by: Dhenain Ambroise <ambroise.dhenain@gmail.com>

Uh oh!

Conversation

Demmonius commented Feb 23, 2021 • edited by Vadorequest Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2021

Uh oh!

github-actions bot commented Feb 23, 2021

Uh oh!

Vadorequest Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

Vadorequest Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

Demmonius Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

Vadorequest Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

Demmonius Feb 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 24, 2021

Uh oh!

github-actions bot commented Feb 24, 2021

Uh oh!

github-actions bot commented Feb 24, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 4, 2021

Uh oh!

github-actions bot commented May 4, 2021

Uh oh!

github-actions bot commented May 8, 2021

Uh oh!

github-actions bot commented May 8, 2021

Uh oh!

github-actions bot commented May 8, 2021

Uh oh!

github-actions bot commented May 8, 2021

Uh oh!

github-actions bot commented May 8, 2021

Uh oh!

github-actions bot commented May 8, 2021

Uh oh!

github-actions bot commented May 8, 2021

Uh oh!

github-actions bot commented May 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Demmonius commented Feb 23, 2021 •

edited by Vadorequest

Loading

Demmonius Feb 23, 2021 •

edited

Loading