fix: fix some crashes caused by improper JSON validation#48
Merged
na-ji merged 2 commits intoUnownHash:mainfrom Nov 28, 2024
Flechaa:fix-crashes
Merged
fix: fix some crashes caused by improper JSON validation#48na-ji merged 2 commits intoUnownHash:mainfrom Flechaa:fix-crashes
na-ji merged 2 commits intoUnownHash:mainfrom
Flechaa:fix-crashes
Conversation
Contributor
|
Thanks for this - it's always good to harden! |
na-ji
approved these changes
Nov 28, 2024
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
Rotom/packages/connections/src/lib/deviceControlConnection.ts
Lines 78 to 120 in e5074b4
Crash example:
Rotom/packages/connections/src/lib/deviceControlConnection.ts
Line 160 in e5074b4
Which will cause the process to crash later in this line:
Rotom/packages/server/src/index.ts
Line 371 in e5074b4
Crash example (takes 60 seconds to crash):