Proposal to allow MITM capability to be given

[jfberry]

Introduce a capability flag which allows MITM to indicate their capability or make requests of controllers.

Implemented as an uint64 to be binary packed (assuming there may be more of these in future)
The suggested initial option is to allow disabling of fast user switching (i.e. return on jail), which is currently implemented with user agent matching.

Comments? This could equally be done with a series of bools so a bitwise flag may be premature optimisation

[jfberry]

The more I think about this, the more I think a bitwise field is probably overkill. Does it really matter if we have 20 flags and this packet becomes 20 bytes longer? :-)
Thoughts from third parties welcome before I switch to a more obviously self-defining boolean

[na-ji]

The more I think about this, the more I think a bitwise field is probably overkill. Does it really matter if we have 20 flags and this packet becomes 20 bytes longer? :-) Thoughts from third parties welcome before I switch to a more obviously self-defining boolean

I was going to comment that bitwise is more than overkill, since it's only on the login proto. Having easy to use boolean would be better.
Also, the supports_compression boolean flag could be considered as a capability.