Merged
Conversation
Fixes ~15-18% performance regression introduced in 20251230 where f-strings were evaluated eagerly even when logging was disabled. See: pdfminer/pdfminer.six#1233 Fix: pdfminer/pdfminer.six#1234
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
awalker4
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ~15-18% performance regression introduced in 20251230 where f-strings were evaluated eagerly even when logging was disabled.
See: pdfminer/pdfminer.six#1233
Fix: pdfminer/pdfminer.six#1234
Note
Addresses a pdf parsing performance issue by updating dependency and aligning versioning.
pdfminer-sixto20260107inrequirements/base.txtand constrain it inrequirements/constraints.in(perf fix)0.0.92inprepline_general/api/__version__.pyandpreprocessing-pipeline-family.yamlCHANGELOG.mdwith the perf fix noteWritten by Cursor Bugbot for commit cd8a7ef. This will update automatically on new commits. Configure here.