write version string like Urcheon #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the possibility to append username (something Urcheon does not) but make it optional and not enabled by default.
Contributor
|
Where does the string go? Can you give an example? |
Member
Author
…/Unvanquished $ ../unvanquished-release-scripts/build-release -v vm
[…]
Creating archive: …/Unvanquished/build/release/vm_0.52.1-20220213-205227-e971ec0.dpkIf |
illwieckz
changed the title
Member
Author
|
So, I improved the version compute, it now takes care of situations like no git repo, no commit, not version tag. I'll probably backport the code to Urcheon as this one is simpler and much faster (I had less git knowledge when I did the code in Urcheon). |
slipher
reviewed
Jul 27, 2022
build-release
Outdated
|
|
||
| if [ -n "${git_last_commit}" ] | ||
| then | ||
| local git_last_commit_short="${git_last_commit:0:7}" |
Contributor
There was a problem hiding this comment.
Use git rev-parse --short HEAD for the short hash
build-release
Outdated
| git_ref="$(git describe --tags --match 'v*' | cut -c2-)" | ||
| git_last_tag="$(git describe --tags --match 'v*' | cut -f1 -d'-' | cut -c2-)" | ||
| git_last_date="$(date --date="@$(git log -1 '--pretty=format:%ct')" -u '+%Y%m%d-%H%M%S')" | ||
| build_version+="$(printVersion)" |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-release: write version string like Urcheon
Keep the possibility to append username (something Urcheon does not) but make
it optional and not enabled by default.
Note: appending username is convenient when modding.