Skip to content

handle search result category chip with missing name#165

Merged
rosemcc merged 2 commits into
masterfrom
hotfix-categories
Nov 7, 2021
Merged

handle search result category chip with missing name#165
rosemcc merged 2 commits into
masterfrom
hotfix-categories

Conversation

@rosemcc
Copy link
Copy Markdown
Contributor

@rosemcc rosemcc commented Nov 3, 2021

Better handling of search results chips to prevent null/undefined errors.

Issue stems from Contentful Delivery API used in the hub-search-proxy returning a linked category which is actually in draft state (possible bug).

More detail: Draft category (i.e. Events) causes bug in search

@rosemcc rosemcc requested a review from Trombach November 3, 2021 03:57
Copy link
Copy Markdown
Contributor

@Trombach Trombach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rosemcc rosemcc merged commit 02c3e81 into master Nov 7, 2021
@rosemcc rosemcc deleted the hotfix-categories branch November 7, 2021 20:06
@rosemcc rosemcc mentioned this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants