Skip to content

Cards refactor#169

Merged
Trombach merged 119 commits into
masterfrom
cards-refactor
Nov 10, 2021
Merged

Cards refactor#169
Trombach merged 119 commits into
masterfrom
cards-refactor

Conversation

@Trombach
Copy link
Copy Markdown
Contributor

@Trombach Trombach commented Nov 8, 2021

In this PR:

  • app-cards has been replaced by new, content-specific cards
  • re-factor of content pages, removing some templates
  • added typescript types for cypress e2e tests

@Trombach Trombach requested a review from rosemcc November 8, 2021 02:03
Copy link
Copy Markdown
Contributor

@rosemcc rosemcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, Lukas. Just a few minor things to address but otherwise it's looking great!!

Comment thread research-hub-web/src/app/components/casestudys/case-study.component.html Outdated
@Trombach Trombach merged commit e853b59 into master Nov 10, 2021
@Trombach Trombach deleted the cards-refactor branch November 10, 2021 01:21
@rosemcc rosemcc mentioned this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants