Expandable page part#170
Merged
Merged
Conversation
Contributor
Author
|
@Trombach ready to check :) |
Trombach
approved these changes
Nov 15, 2021
Contributor
Trombach
left a comment
There was a problem hiding this comment.
This is really cool. I like how the component loads the content itself instead of relying on the data being passed in! I've added one comment about the async request to bring it more in line with what I'm doing with the content page refactor. Take a look and let me know what you think 😄
Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature for rich text / body media: Expandable Page Part
This is to handle a new page part content type in Contentful called 'Expand'. Expands can be used within rich text in a page entry. The Expand is itself a rich text field. Currently Expands cannot contain a nested Expand due to the field validation settings in Contentful, however this implementation would allow that use case if necessary. They can however, contain any other type of rich text entry (entries, assets, hyperlinks).
User story
As a content author I want to add collapsible sections to my page so that I can have long pages with subsections which readers will be able to easily skim and dip into as need dictates.
Implementation notes