Content Page refactor#175
Merged
Merged
Conversation
commit 2f22e09 Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 15:31:14 2021 +1300 fixed single quotes commit 2dc309e Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 15:12:24 2021 +1300 removed subhub list from subhub component commit 53b9847 Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 15:11:23 2021 +1300 removed software list from software component commit fcb5263 Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 15:09:07 2021 +1300 removed service list from service component commit 9207298 Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 15:07:22 2021 +1300 removed funding list from funding component commit f5091c0 Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 15:04:12 2021 +1300 removed event list from event component commit bd60389 Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 15:00:24 2021 +1300 removed all equipment query commit feb33a4 Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 14:53:26 2021 +1300 removed equipment list from equipment component commit 9c811a8 Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 14:49:28 2021 +1300 removed case study list from case study component commit 22c4b6d Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 14:43:57 2021 +1300 removed articles list from article component commit 8c3e32f Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 14:19:33 2021 +1300 broke out subhub list commit b0bbef7 Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 13:46:42 2021 +1300 broke out software list commit 0ce590b Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 13:33:38 2021 +1300 broke out service list commit ac7f5cd Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 13:04:01 2021 +1300 changed import for funding route commit 7b0289b Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 12:35:12 2021 +1300 broke out funding list commit 877c674 Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 11:48:14 2021 +1300 broke out event list commit 8f14525 Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 11:28:38 2021 +1300 broke out equipment list commit 4b76f8b Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 11:17:19 2021 +1300 broke out case study list commit 51d557c Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 11:06:45 2021 +1300 unsubscribe on destroy commit 8544616 Merge: c48690f 486d289 Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 10:32:34 2021 +1300 Merge branch 'master' into build-new-content-types-list-page commit c48690f Author: Luke <lukas.trombach@auckland.ac.nz> Date: Thu Oct 14 10:32:12 2021 +1300 broke out article list
rosemcc
reviewed
Nov 16, 2021
rosemcc
reviewed
Nov 16, 2021
Contributor
|
Use page title service on the list pages |
rosemcc
approved these changes
Nov 23, 2021
Contributor
rosemcc
left a comment
rosemcc
left a comment
There was a problem hiding this comment.
Hey Lukas, looks good to me. I've added a few minor changes that you might want to just check and make sure I didn't mess anything up ;)
Unit and e2e tests are passing.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request: