E2e fixtures#243
Merged
Merged
Conversation
…ia specific ids for testing
Trombach
approved these changes
Mar 7, 2022
Contributor
Trombach
left a comment
There was a problem hiding this comment.
Just a few suggestions. Otherwise looks good to me!
Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com>
Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the use of fixtures (mocked data) for some of the e2e tests. We have previously been unable to test certain page types, including Funding and Case Study, because they are all SSO protected, and also we have not been able to test certain page elements easily. Intercepting graphql requests and returning mocked data in the response can solve these problems, without having to add functionality for automated login for testing the sso protected page types.
Solution
cy.intercept('POST', Cypress.env('graphql_server'), (req) => { if (hasOperationName(req, 'GetArticleBySlug')) { req.alias = 'gqlGetArticleBySlug'; req.reply({ fixture: 'article' }); } });Screenshots
N/A
Testing
Lots of e2e test changes/additions
Have the changes been checked in the following browsers?
N/A