Fix draft assets error#248
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a fix for a bug where pages that are published with a link to a draft asset or a link to a page with a draft asset would not load, and would be directed to /error/500. The error is an internal server error from the graphql API and is classed as a 'Query execution error'. Because data is still returned for the page in question, the page should still load, albeit with some missing data (the draft asset will show as null in the returned data), and the error should be ignored. This would be very similar to how we currently handle draft linked entries - they are essentially ignored, and the page is still rendered, minus the draft entries.
Solution
In AppModule in te graphql client onError handler, there is now a check for the draft asset error:
graphQLErrors[0].message.includes('Query execution error. Link from entry')If this error occurs then it is ignored and the page will still load with whatever data has been returned from the server. Because the app already handles null values the UI should be still rendered correctly.
Screenshots
N/A
Testing
Manual testing for the following cases:
Have the changes been checked in the following browsers?
N/A